K8SPG-407 Allow perconapgclusters/finalizers in role #229
Conversation
Allow perconapgclusters/finalizers to ensure block deletion permissions are granted. This will otherwise cause a apply failure when the operator tries to instantiate a CR on OpenShift 4.10+ (tested)
|
|
|
@tplavcic Can you have a look at this? |
|
@thomaspetit Need to discuss it within team so somebody will have a look. To me this doesn't look like helm chart specific but rather general issue with the current release. |
|
Can you tell me why this is not chart specific, the role is defined in the chart as it is? Is this role generated automatically from somewhere? If you want I can probably make the change upstream if I know where to look :) |
|
@thomaspetit what @tplavcic is talking about is the role in the operator repo. We should also fix it there, if you're up to it you can create a PR but you don't need to, we'll do in the next release anyway. |
charts/pg-operator/Chart.yaml
Outdated
| @@ -2,7 +2,7 @@ apiVersion: v2 | |||
| name: pg-operator | |||
| description: 'A Helm chart to deploy the v2 version of Percona Operator for PostgreSQL.' | |||
| type: application | |||
| version: 2.2.0 | |||
| version: 2.2.1 | |||
There was a problem hiding this comment.
@thomaspetit please bump the version to 2.2.2 because #230 was merged :( P.S. thank you for PR!
There was a problem hiding this comment.
Also, I am not sure that all these create/get/list/patch/update/watch verbs are needed for 'perconapgclusters/finalizers'. Only an update can be enough.
There was a problem hiding this comment.
Fixed! Sorry for the delay ;)
There was a problem hiding this comment.
@thomaspetit Please bump it one more time to 2.2.3 and we will merge it.
There was a problem hiding this comment.
Can you tell me why? Currently the version is 2.2.1 on main while this new version will be 2.2.2. Am I missing something? :-) Sorry for the question..
There was a problem hiding this comment.
Sorry, It was my mistake. :) Thank you for your contribution.
hors
changed the title
Allow perconapgclusters/finalizers to ensure block deletion permissions are granted. This will otherwise cause a apply failure when the operator tries to instantiate a CR on OpenShift 4.10+ (confirmed and tested with this version).
The operator will complain with following error:
This is the interesting error you see:
cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on